-
Notifications
You must be signed in to change notification settings - Fork 12
Start support for open with in metadata #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Begin with linux as it's just metadata :)
|
Trying to fully grasp this without additional documentation was a bit of guesswork for me until I found https://specifications.freedesktop.org/desktop-entry/latest/mime-types.html - should we maybe reference it somehow? |
Hmm, well - mime type is a universal thing and I don't want to link this to a system specific doc. A documentation page will be needed - but what is the intent of linking it back to the specifics of desktop entries? |
Not necessary, it was just for general clarity, because the big picture wasn't immediately obvious. |
| Development map[string]string `toml:",omitempty"` | ||
| Release map[string]string `toml:",omitempty"` | ||
| Source *AppSource `toml:",omitempty"` | ||
| OpenWith *OpenWith `toml:",omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am late on review but shouldn't the naming on this be more like CanOpen *ContentTypes? "OpenWith" sounds more like the OS side of the equation, where the user is choosing which app it wants to associate with a given file type. This is advertising to the OS what types you can open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Drew, that is a great point. I will refactor on the landed code.
Begin with linux as it's just metadata :)
Testing with an app of mine, adding The following to FyneApp.toml: