Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onchanged callback to support actions on widget change #37

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Add onchanged callback to support actions on widget change #37

merged 2 commits into from
Feb 3, 2025

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Feb 1, 2025

To allow more features.

andydotxyz
andydotxyz requested changes Feb 2, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was documented that OnChanged is optional, but it's called irrespective of nil - won't that crash?

andydotxyz
andydotxyz approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah never mind sorry, I see the defaulting of the onchanged in the public function - nice touch

@andydotxyz andydotxyz merged commit ba84006 into fyne-io:main Feb 3, 2025
7 checks passed
@sdassow sdassow deleted the feature/editor-onchanged-callback branch February 3, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdassow @andydotxyz