feat: Add extensive loggers #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin1111
reviewed
Oct 8, 2024
qbosdk/apis/api_base.py
Outdated
|
|
||
|
|
||
| logger = logging.getLogger(__name__) | ||
| logger.level = logging.WARNING |
| @@ -246,6 +253,8 @@ def _post_request(self, data, api_url): | |||
| if response.status_code == 200: | |||
| result = json.loads(response.text) | |||
| return result | |||
|
|
|||
| logger.debug('Response for post request: %s', response.text) | |||
|
|
|||
There was a problem hiding this comment.
let's do logger.info for all non 2xx status code
logger.debug you can move it to 2xx block
qbosdk/apis/api_base.py
Outdated
| @@ -9,6 +9,11 @@ | |||
| from ..exceptions import WrongParamsError, InvalidTokenError, QuickbooksOnlineSDKError, \ | |||
| NoPrivilegeError, NotFoundItemError, ExpiredTokenError, InternalServerError | |||
|
|
|||
| import logging | |||
qbosdk/apis/api_base.py
Outdated
| @@ -9,6 +9,11 @@ | |||
| from ..exceptions import WrongParamsError, InvalidTokenError, QuickbooksOnlineSDKError, \ | |||
| NoPrivilegeError, NotFoundItemError, ExpiredTokenError, InternalServerError | |||
|
|
|||
| import logging | |||
|
|
|||
There was a problem hiding this comment.
pls bump version as well
ashwin1111
reviewed
Oct 8, 2024
qbosdk/apis/api_base.py
Outdated
| @@ -118,11 +117,14 @@ def _query_get_all_generator(self, object_type: str, url: str) -> Generator[Dict | |||
| if not query_response or object_type not in query_response: | |||
| break | |||
|
|
|||
| logger.debug('Response for get request for url: %s, %s', url, query_response) | |||
There was a problem hiding this comment.
print response.text - I don't want any data to be missed
qbosdk/apis/api_base.py
Outdated
| except requests.exceptions.HTTPError as err: | ||
| logger.info('Response for get request for url: %s, %s', url, err.response) |
qbosdk/apis/api_base.py
Outdated
| @@ -242,19 +248,19 @@ def _post_request(self, data, api_url): | |||
| 'Authorization': 'Bearer {0}'.format(self.__access_token) | |||
| } | |||
|
|
|||
| logger.debug('Payload for post request: %s', data) | |||
ashwin1111
approved these changes
Oct 8, 2024
| @@ -259,7 +259,7 @@ def _post_request(self, data, api_url): | |||
| result = json.loads(response.text) | |||
| return result | |||
|
|
|||
| logger.info('Payload for post request: %s', data) | |||
| logger.debug('Payload for post request: %s', data) | |||
There was a problem hiding this comment.
this should be before 257 block, we don't end up reaching here since we're returning at 260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.