Fix multiplicities #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
fxamacker
added a commit
that referenced
this pull request
Mar 14, 2023
Changed composite-type.fields from + to *. Changed restricted-type-value.restrictions from + to *. Basically, this changes "one or more" to "zero or more" in order to be consistent with what was done in: #66
fxamacker
added a commit
to onflow/cadence
that referenced
this pull request
Mar 14, 2023
Updated Go comments containing CCF specs in CDDL notation. Specifically, changed CDDL notation representing "one or more" to "zero or more" for: - composite-value.fields - composite-type.fields - composite-type-value.fields See CCF specification PRs: - fxamacker/ccf_draft#66 - fxamacker/ccf_draft#67
fxamacker
added a commit
to onflow/cadence
that referenced
this pull request
Mar 14, 2023
Updated Go comments containing CCF specs in CDDL notation. Specifically, changed CDDL notation representing "one or more" to "zero or more" for: - restricted-type.restrictions - restricted-type-value.restrictions See CCF specification PRs: - fxamacker/ccf_draft#66 - fxamacker/ccf_draft#67
fxamacker
added a commit
to onflow/cadence
that referenced
this pull request
Mar 14, 2023
CCF specs were updated to allow "zero or more" sortable items rather than "one or more". Given this, update CCF codec to check for zero items before sorting. Relevant changes to CCF specification include: - fxamacker/ccf_draft#66 - fxamacker/ccf_draft#67 Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while reviewing onflow/cadence#2364
There might be more cases that need to be fixed.