Skip to content

Conversation

@krzema12
Copy link
Contributor

@krzema12 krzema12 commented Jan 1, 2025

This PR adds typings for this action, using https://github.com/typesafegithub/github-actions-typing. Thanks to this, one can consume this action in a type-safe way using https://github.com/typesafegithub/github-workflows-kt.

@fwilhe2
Copy link
Owner

fwilhe2 commented Jan 1, 2025

Hey @krzema12, thanks for your contribution, I was not aware of that. Looks cool, can you share how this is used?

@fwilhe2 fwilhe2 merged commit 674514b into fwilhe2:main Jan 1, 2025
@krzema12
Copy link
Contributor Author

krzema12 commented Jan 2, 2025

Sure! The only use of this I'm aware of is by https://github.com/typesafegithub/github-workflows-kt. More precisely, there's a Maven-compatible server that vends the Kotlin bindings for the actions on demand. It generates Kotlin code and compiles it on the fly, using the typings to know what Kotlin types should be used by the binding. You can read more about this project here: https://www.javaadvent.com/2024/12/the-journey-of-providing-kotlin-bindings-for-github-actions.html

I'm about to use your action here: typesafegithub/github-workflows-kt#1758

There's one more thing left to do: can I ask you to release a new version of this action? Only then the typings will be usable by the mechanism described above.

@fwilhe2
Copy link
Owner

fwilhe2 commented Jan 2, 2025

Thanks for sharing. This looks awesome.

There's one more thing left to do: can I ask you to release a new version of this action? Only then the typings will be usable by the mechanism described above.

I've seen you already use v0.11.0 which I released tonight. Let me know if anything needs to be fixed.

@krzema12
Copy link
Contributor Author

krzema12 commented Jan 2, 2025

All is fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants