Skip to content

Conversation

@fwdekker
Copy link
Owner

A rewrite of nearly all tests for Randomness. Tests were not updated while rewriting Randomness itself because of how unstable the code base and design were, so I postponed that until now. The structure of the tests is mostly the same as before; this PR mostly consists of

  • Removing tests for classes that no longer exist
  • Adding tests for newly introduced classes
  • Minor changes to production code to improve code quality or to fix (usually minor) bugs

This won't increase coverage, but does actually cover specific requirements set in those methods' documentations. So *true* coverage increases, but the arbitrary number doesn't.
Such as helper classes and such.
...once again. This time to allow TemplateList to be a State but not a Scheme.
@fwdekker fwdekker added the code quality Code changes without behavior changes label Aug 19, 2021
@fwdekker fwdekker added this to the v3.0.0 milestone Aug 19, 2021
@fwdekker fwdekker self-assigned this Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #395 (a8b4c4d) into dev (390e48f) will increase coverage by 13.87%.
The diff coverage is 90.46%.

Impacted file tree graph

@@              Coverage Diff              @@
##                dev     #395       +/-   ##
=============================================
+ Coverage     70.22%   84.09%   +13.87%     
- Complexity      216      374      +158     
=============================================
  Files            43       43               
  Lines          1669     1314      -355     
  Branches        222      190       -32     
=============================================
- Hits           1172     1105       -67     
+ Misses          456      166      -290     
- Partials         41       43        +2     

@fwdekker fwdekker merged commit c27259c into dev Aug 19, 2021
@fwdekker fwdekker deleted the v3-test-rewrite branch August 19, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Code changes without behavior changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants