Skip to content

Conversation

@fwdekker
Copy link
Owner

@fwdekker fwdekker commented Jul 6, 2021

Fixes #382.

The issue was that I had added serializedSymbolSets and serializedActiveSymbolSets as variants of symbolSets and activeSymbolSets to ensure that emoji would not get lost when saving preferences. I then set the other variants of this field to be transient, but instead of making them abstractions over the serialized fields, I made them into separate fields. The result was that changes were stored only in the transient fields, but not the fields that were actually written to the preferences file.

@fwdekker fwdekker added the bug Something isn't working label Jul 6, 2021
@fwdekker fwdekker self-assigned this Jul 6, 2021
Resolves Detekt style errors.
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #383 (0f60c36) into master (1434af2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #383   +/-   ##
=========================================
  Coverage     80.78%   80.78%           
  Complexity      216      216           
=========================================
  Files            39       39           
  Lines          1452     1452           
  Branches        168      168           
=========================================
  Hits           1173     1173           
  Misses          239      239           
  Partials         40       40           

@fwdekker fwdekker merged commit 465fda1 into master Jul 6, 2021
@fwdekker fwdekker deleted the symbol-set-settings branch July 6, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RANDomness doesn't save settings for Symbol sets

1 participant