Prevent symbol set setting truncation #383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #382.
The issue was that I had added
serializedSymbolSetsandserializedActiveSymbolSetsas variants ofsymbolSetsandactiveSymbolSetsto ensure that emoji would not get lost when saving preferences. I then set the other variants of this field to be transient, but instead of making them abstractions over the serialized fields, I made them into separate fields. The result was that changes were stored only in the transient fields, but not the fields that were actually written to the preferences file.