FvwmBacker example

[rasatpc]

FvwmBacker use and advance example.

[somiaj]

Good start, here are some comments to clean up the page a bit.

[somiaj]

You don't want to run modules from InitFunction, they need to be launched each time. Add this to StartFunction. In general the use of InitFunction is discouraged, instead use Test (Init) Command in the StartFunction, as done in the default-config.

[somiaj]

Use $[FVWM_USERDIR]/images/... instead.

[somiaj]

This is overkill, you are setting the exact same image for all pages, so just remove the , Page X Y bit. See above comment, just add a small comment stating that it is possible to control each pages, but this example doesn't need that.

[somiaj]

It is good practice to wrap this into the StartFunction.

[somiaj]

This sentence and mentioning FvwmPager here is a bit awkward to me. I do like that you link to it in the example below, and show that you can make the pager and the desktop match. But up here, there is no need to mention the pager, just focus on this can be used to run commands to set backgrounds on desk and/or page changes.

[somiaj]

Maybe add another example to state that, not only can FvwmBacker give each desktop a unique look, it can also be used to change the background for each Page as well, and then provide some examples.

[rasatpc]

All comments are updated.

[somiaj]

Thanks for the updates, still a few small things I noticed (some of the configs woudln't work as written). Also you may want to comment about adding both FvwmPager and FvwmBacker to the StartFunction in your eample.

[somiaj]

fvwm-root would fail with a .jpg image here.

[somiaj]

This example wouldn't work, first you need to run some program to set the background, such Exec exec fvwm-root. And if you are going to use $HOME, at least use $[HOME].

[rasatpc]

I will test each sample.

FvwmBacker to the StartFunction in your example.

I did a test and added in default config. Doesn't work in 1.1.1, and also not in earlier fvwm versions (1.0.6)

DestroyFunc StartFunction
AddToFunc   StartFunction
+ I Test (Init) InitBackground
+ I Module FvwmButtons RightPanel
+ I Module FvwmEvent EventNewDesk
+ I Module FvwmMFL
+ I Module FvwmBacker

With FvwmConsole..... Module FvwmBacker works fine.

[rasatpc]

Workable correction, all are tested on default config, including feh for jpg image.

[somiaj]

@rasatpc StartFunction only runs right after the initial configuration file is parsed, so it is preferred to run stuff at start from there, so the configuration file is full read before doing anything.

Since you are testing from FvwmConsole, it won't work with StartFunction, since you have already finished initialization, when testing you'll just want to launch the module. But if your goal is for something to copy/paste into their config file then restart fvwm, StartFunction is preferable.

[somiaj]

I am always torn if we should use feh in examples or not, as this isn't default, and users may have other tools to choose. Probably fine to use feh here, but then there is no reason to use fvwm-root, mixing them may only lead to confusion as to why one is used on .png and one is used on .jpg. I would stick to a single option in the configuration example, then maybe add a comment about how fvwm-root only supports .xpm, .png, and .svg, and a tool like feh would support more image formats and allow you setting wallpapers per monitor (which fvwm-root cannot do).

[somiaj]

There is little reason to seperate this into two different highlight blocks, just use a single block for this, maybe put a # Start Modules when fvwm starts. Note you also need to add FvwmBacker to this, otherwise it won't run and the configuration won't do anything.

[rasatpc]

Before Example, it says.... "changes will not be implemented until you instruct Fvwm to update the screens
during the initialization:
AddToFunc StartFunction I Module FvwmBacker

Or, better to say it again?

About, StartFunction, I will post on forum.

[somiaj]

What the StartFunction does is well documented, this does not need to be posted on the forums. Read the manual page or https://www.fvwm.org/Wiki/Config/Functions/StartFunction/.

[rasatpc]

I found the reason why AddToFunc StartFunction I Module FvwmBacker or by adding + I Module FvwmBacker directly to function StartFunction, does not work on my config system.
It only works when all functions, modules, etc. run in one config. In my system (Kise and myExt), all run as individual small configs (scripts). For StartFunction to work, I have to add the command somewhere. This is why I don't use StartFunction except for InitBackground.

Tomorrow, I will correct the comments.

[somiaj]

That sounds like an error with how you are setting things up. You should load all your configurations from a central config file, so you can use the StartFunction appropriately. But the StartFunction is run after fvwm has finished its initialization of the configuration file it read, if you do pass this off to other tools, yes you are correct it won't work.

[somiaj]

Note, it is not as you said about a 'single config file', StartFunction still functions correctly if you split your config up into multiple conig files. Maybe think about your design a bit more, but that is beyond the scope of this PR. I think it is just best we recommend adding things like modules to StartFunction as that is appropriate for most users who put this into their config file and restart.

[rasatpc]

This PR is ready.

[rasatpc]

The StartFunction problem was in my system. It took some time to trace the bug.
Now, everything is working fine.

[somiaj]

I am going to merge this. I have a few more minor updates I'll just add on top of this.

[rasatpc]

Thanks, it looks great.