Multiple FvwmPager Fixes #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In working on other things I noticed the following errors. Putting
here instead of tacking to other features.
* Keep fp->virtual_scr.Vx and fp->virtual_scr.Vy in sync.
* Remove some old comments left in from some older merge conflicts.
* Fix some desk comparisons that were incorrectly determining
if a window was on the correct desk or not.
* Fix an issue where the icon window wasn't being updated correctly.
* Fix a logic issue in determining if a monitor is being tracked.
Make explicit the fact that the monitor_mode and is_tracking_shared are local to FvwmPager -- and don't use the definitions in libfvwm3 as this is misleading.
somiaj
force-pushed
the
js/pager-bugfixes
branch
2 times, most recently
from
afca06e to
e4e6f07
Compare
The 'desk N' option can be provided to the Move command before any positional arguments to state the final desk to place the window on. This serves two functions, first allowing moving the windows position and desk in a single command, and second to be able to override which desk a window ends up on when switching between monitors (currently a window is always moved to the desk of the new monitor when moving windows between monitors, and this may not always be desirable). This is primarily for the FvwmPager to better state the location of the windows it moves in a single command and override the default behavior of updating desks on monitor changes.
Initial configuration broadcasts are parsed in ParseOptions(). This method wasn't properly updated to match and scan for all broadcasts listed in list_config_info(), thus not all pager settings matched the state of fvwm until it issued a new broadcast to update things. This fixes that by ensuring that ParseOptions() scans for initial broadcasts. Helper methods were added to minimize duplicate code.
The IconView was only showing the minimum desk, unless the pager was already in fAlwaysCurrentDesk mode. This adds a variable to keep track of the icon desk separately, so it can always show the current desk of the monitor it is tracking.
Update the movement code of the pager to use the 'desk n' option in the Move command. This makes it so the pager can reliably tell fvwm where to move a window too, and ensure the window is placed on the correct desk. Disabling the feature for now that would FlipFocus the window if it was put on the same desk as the current monitor, as this may not always be desirable. Will make this an optional configuration in the future.
somiaj
force-pushed
the
js/pager-bugfixes
branch
from
e4e6f07 to
cb319bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of bugfixes I've been trying to hunt down, and things I noticed when trying to add new features. I have split the bugfixes out, before working on new features. This includes:
desk any monitor switched to).