default-config: Don't close terminal if manpage not found. #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
force-pushed
the
js/hide-man-menu
branch
5 times, most recently
from
b9a97d1 to
56f3614
Compare
|
Updated the approach here. Instead of testing for the manual page, if opening them fails, keep the terminal open using |
somiaj
changed the title
somiaj
force-pushed
the
js/hide-man-menu
branch
from
56f3614 to
31d0e42
Compare
ThomasAdam
reviewed
Oct 17, 2024
somiaj
force-pushed
the
js/hide-man-menu
branch
from
31d0e42 to
ab882a1
Compare
When viewing a manual page using the "Help" menu in the default-config, if the manual page is not found, don't close the terminal, instead use the 'read' command to wait for user input. This will require the user to hit 'Enter' or close the terminal manually. This ensures that if the manual pages are not installed the user gets a message from man saying that the manual page cannot be found vs just flashing a terminal. Update fvwm3.pot file since a new translation string was added.
somiaj
force-pushed
the
js/hide-man-menu
branch
from
ab882a1 to
a81db3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show the "Help" menu if the manual pages are installed. This is done by testing for the fvwm3all manual page, and the item entry to popup the "Help" menu is only added to the root menu if the fvwm3all manual page exists.