Fix race condition in .download directory creation #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple packages are downloaded in parallel via asyncio, they can simultaneously attempt to create the .download directory. The current check-then-create pattern causes [Errno 17] File exists errors. This changes os.makedirs() to use exist_ok=True, which is thread-safe and handles the race condition properly. Fixes issues where downloads fail with: - ERROR: [Errno 17] File exists: '/io/packages/.download' This occurs frequently in CI environments where packages are downloaded in parallel during ivpm update operations.
mballance
added a commit
to zuspec/zuspec-fe-pss
that referenced
this pull request
Dec 27, 2025
Install ivpm from mballance/ivpm@fix-download-race-condition which fixes the [Errno 17] File exists race condition when creating the .download directory during parallel package downloads. This should eliminate the need for all the manual ANTLR and debug-mgr workarounds, as ivpm will now properly download and extract packages. Related: fvutils/ivpm#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple packages are downloaded in parallel via asyncio, they can simultaneously attempt to create the .download directory. The current check-then-create pattern causes
[Errno 17] File existserrors.This changes
os.makedirs()to useexist_ok=True, which is thread-safe and handles the race condition properly.Fixes:
ERROR: [Errno 17] File exists: '/io/packages/.download'ivpm updateoperations.Testing:
This has been tested with the zuspec-parser project which was consistently hitting this race condition during CI builds with multiple packages being downloaded simultaneously.