-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upkeeping: Links, language, style #47
Conversation
…emoved with XCode 8 Discussion: https://forums.developer.apple.com/thread/48936
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping this up to date. Just a few small requests.
@@ -351,9 +352,10 @@ You can include the original [vector graphics (PDFs)][vector-assets] produced by | |||
|
|||
### Naming | |||
|
|||
Apple pays great attention to keeping naming consistent, if sometimes a bit verbose, throughout their APIs. When developing for Cocoa, you make it much easier for new people to join the project if you follow [Apple's naming conventions][cocoa-coding-guidelines]. | |||
Apple pays great attention to keeping naming consistent. Adhering to their [coding guidlines for Objective-C][cocoa-coding-guidelines] and [API design guidlines for Swift][swift-api-design-guidlines] makes it much easier for new people to join the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typos: guidlines - > guidelines
|
||
[timezones-youtube]: https://www.youtube.com/watch?v=-5wpm-gesOY | ||
[datetools-github]: https://github.com/MatthewYork/DateTools | ||
|
||
### Auto Layout Libraries | ||
If you prefer to write your views in code, chances are you've met either of Apple's awkward syntaxes – the regular `NSLayoutConstraint` factory or the so-called [Visual Format Language][visual-format-language]. The former is extremely verbose and the latter based on strings, which effectively prevents compile-time checking. Fortunately, they've addressed the issue in iOS 9, allowing [a more concise specification of constraints][nslayoutanchor]. | ||
If you prefer to write your views in code, chances are you've heard of either Apple's awkward syntaxes – the regular `NSLayoutConstraint` factory or the so-called [Visual Format Language][visual-format-language]. The former is extremely verbose and the latter based on strings, which effectively prevents compile-time checking. Fortunately, they've addressed the issue in iOS 9, allowing [a more concise specification of constraints][nslayoutanchor]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stylistic change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely no native, but I don't think you can say "to meet either of A or B". I think you can only say "to meet either A or B" or "to hear of either A or B".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds perfectly natural to my ears (also see plenty of examples at http://www.linguee.fr/anglais-francais/traduction/meet+either+of+the+above.html), but your version is arguably less convoluted, so let's go with it. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, the new wording sounds wrong – I would write "chances are you've come across one of Apple's awkward syntaxes ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh shit, you're right, there's a missing "of". Seems my brain just auto-filled it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be "heard of either of Apple's" of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I'm perfectly happy with the original wording as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree – either original wording, or new wording with "of" added (or my suggestion) would be fine.
@@ -110,13 +110,13 @@ will update all pods to the newest versions permitted by the Podfile. You can us | |||
|
|||
[Carthage][carthage] takes the ["simple, not easy"][simple-made-easy] approach by building your dependencies into binary frameworks, without magically integrating them with your project in any way. This also greatly reduces build times, because your dependencies have already been compiled by the time you start building. | |||
|
|||
There is no centralized repository of projects, which means any library that can be compiled into a framework supports Carthage out of the box. Note that dynamic frameworks are only available from iOS 8 onwards. | |||
There is no centralized repository of projects, which means any library that can be compiled into a framework supports Carthage out of the box. Note that dynamic frameworks are only available from iOS 8 onward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stylistic change. Although personally, I think I prefer onwards.
http://english.stackexchange.com/questions/59137/onward-vs-onwards
Fixes a small number of things: