Improve DPM and NCM performance #734

DavidLiu506 · 2022-01-20T22:36:31Z

In DPM, if neighbor state already pushed to NCM, don't push again.
In NCM, query all neighbor state that ACA needed.
Enable the partition awareness feature within scaling Kubernetes enviroment.
Add service account that allows Alcor access Kubernetes API server.

lgtm-com · 2022-01-20T22:59:16Z

This pull request introduces 1 alert when merging dff6e4f into 6d727ac - view on LGTM.com

new alerts:

1 for Unused format argument

lgtm-com · 2022-01-25T21:57:31Z

This pull request introduces 1 alert when merging 1bf4df8 into 4987793 - view on LGTM.com

new alerts:

1 for Unused format argument

lgtm-com · 2022-01-25T23:15:19Z

This pull request introduces 1 alert when merging 3dbd205 into 4987793 - view on LGTM.com

new alerts:

1 for Unused format argument

xieus

First batch of comments. Thank you @DavidLiu506

kubernetes/db/ignite/ignite_alcor.yaml

kubernetes/db/ignite/ignite_config.xml

kubernetes/services/route_manager.yaml

xieus · 2022-01-25T23:16:51Z

lib/pom.xml

+        <dependency>
+            <groupId>org.apache.ignite</groupId>
+            <artifactId>ignite-kubernetes</artifactId>
+            <version>2.12.0</version>


Should we upgrade our ignite-core dependency to 2.12 as well? The master stays on 2.10.

<dependency> <groupId>org.apache.ignite</groupId> <artifactId>ignite-core</artifactId> <version>2.10.0</version> </dependency>

Good suggestions. will try it.

In Medina, it used ignite lib8. it seems like 2.10 not works on kubernetes. @cj-chung

xieus

@DavidLiu506 Please take a look at the comment.

lib/src/main/java/com/futurewei/alcor/common/db/ignite/IgniteConfiguration.java

...e_manager/src/main/java/com/futurewei/alcor/dataplane/client/grpc/DataPlaneClientImplV2.java

..._plane_manager/src/main/java/com/futurewei/alcor/dataplane/service/impl/NeighborService.java

xieus · 2022-01-26T00:06:58Z

...ger/src/main/java/com/futurewei/alcor/netwconfigmanager/client/gRPC/GoalStateClientImpl.java

+    @Autowired
+    private ResourceStateCache resourceStateCache;
+


@DavidLiu506 I don't think gRPC client is a good place to read/write a cache, which is usually supposed to be done in upper service layer.

Good suggestions. Thanks!

We could move this post 1/30 release. Create an issue to track this enhancement item #735

...java/com/futurewei/alcor/netwconfigmanager/service/impl/GoalStatePersistenceServiceImpl.java

kubernetes/services/dpm_manager.yaml

services/port_manager/src/main/resources/application.properties

lgtm-com · 2022-01-26T03:40:58Z

This pull request introduces 1 alert when merging c0a19ee into 4987793 - view on LGTM.com

new alerts:

1 for Unused format argument

lgtm-com · 2022-01-26T20:59:48Z

This pull request introduces 1 alert when merging 97e513a into 4987793 - view on LGTM.com

new alerts:

1 for Unused format argument

lgtm-com · 2022-01-26T22:21:44Z

This pull request introduces 1 alert when merging a9d930e into 4987793 - view on LGTM.com

new alerts:

1 for Unused format argument

lgtm-com · 2022-01-26T23:50:47Z

This pull request introduces 1 alert when merging 5b8dec8 into 58440cc - view on LGTM.com

new alerts:

1 for Unused format argument

lgtm-com · 2022-02-01T00:10:26Z

This pull request introduces 1 alert when merging 91a3790 into 58440cc - view on LGTM.com

new alerts:

1 for Unused format argument

DavidLiu506 · 2022-02-01T01:23:18Z

This PR works on Medina and Jenkins

xieus

LGTM!

DavidLiu506 and others added 30 commits June 29, 2021 12:07

Update router manager api

04cbb1e

Update code

4c100e5

Update code

e38bcf9

Update router manager

067a988

Update router manager

dd5dafd

Merge router manager service api code

aa76562

Fix getVpcRouteTables

8ae37db

Fix getVpcRouteTable

f0462ae

Update RouterController

976883f

Update code

ef7a2d2

Update code

670dcc6

Update code

59a65f0

pull alcor code

1178f61

Merge branch 'futurewei-cloud:master' into master

5a98d10

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

e4e0792

Merge branch 'futurewei-cloud:master' into master

ae15be0

Merge branch 'futurewei-cloud:master' into master

9c88b19

Merge branch 'futurewei-cloud:master' into master

9be2bb9

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

733872a

Merge branch 'futurewei-cloud:master' into master

b3154ae

Merge branch 'master' of https://github.com/DavidLiu506/alcor

e2bed17

Merge branch 'futurewei-cloud:master' into master

7c5013e

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

ac7acf8

Merge branch 'futurewei-cloud:master' into master

bcc0716

Merge branch 'futurewei-cloud:master' into master

c499d9c

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

329e216

Merge branch 'futurewei-cloud:master' into master

43435bd

Merge branch 'master' of https://github.com/futurewei-cloud/alcor

9b51767

Merge branch 'futurewei-cloud:master' into master

2f68edb

Merge branch 'master' of https://github.com/DavidLiu506/alcor

a6b1122

Update code

dff6e4f

DavidLiu506 requested review from cj-chung and xieus January 20, 2022 22:36

xieus assigned DavidLiu506 Jan 24, 2022

xieus added deployment and upgrade k8s perf testing Performance Testing labels Jan 24, 2022

xieus added this to the Version 1.0.2022.01.30 milestone Jan 24, 2022

Update code

1bf4df8

Update code

3dbd205

xieus reviewed Jan 25, 2022

View reviewed changes

xieus reviewed Jan 26, 2022

View reviewed changes

Update code

c0a19ee

Update code

97e513a

Update code

a9d930e

Update code

5b8dec8

Update code

91a3790

xieus self-requested a review February 1, 2022 05:11

xieus approved these changes Feb 1, 2022

View reviewed changes

xieus merged commit acbea34 into futurewei-cloud:master Feb 1, 2022

DavidLiu506 deleted the alcor/ncm branch May 28, 2022 01:25

Improve DPM and NCM performance #734

Improve DPM and NCM performance #734

Uh oh!

Conversation

DavidLiu506 commented Jan 20, 2022 • edited by xieus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Jan 20, 2022

Uh oh!

lgtm-com bot commented Jan 25, 2022

Uh oh!

lgtm-com bot commented Jan 25, 2022

Uh oh!

xieus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xieus Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

DavidLiu506 Jan 26, 2022

Choose a reason for hiding this comment

Uh oh!

DavidLiu506 Jan 26, 2022

Choose a reason for hiding this comment

Uh oh!

xieus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xieus Jan 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DavidLiu506 Jan 26, 2022

Choose a reason for hiding this comment

Uh oh!

xieus Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Jan 26, 2022

Uh oh!

lgtm-com bot commented Jan 26, 2022

Uh oh!

lgtm-com bot commented Jan 26, 2022

Uh oh!

lgtm-com bot commented Jan 26, 2022

Uh oh!

lgtm-com bot commented Feb 1, 2022

Uh oh!

DavidLiu506 commented Feb 1, 2022

Uh oh!

xieus left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DavidLiu506 commented Jan 20, 2022 •

edited by xieus

Loading

xieus Jan 26, 2022 •

edited

Loading