This repository was archived by the owner on Mar 31, 2023. It is now read-only.
[Deployment] K8s deployment enhancement #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yanmo96
commented
Jan 18, 2022
yanmo96
commented
- Rather than wait certain time for k8s to be active, now the deployment script will check the status of k8s pod to make sure they are all up and running before continue. Thus can tolerate different deployment situations.
- Fixed some url links for ignite config files.
cj-chung
reviewed
Jan 19, 2022
|
|
||
| while [ "$numberOfRnningPods" != "$numberOfAllPods" ]; | ||
| do | ||
| sleep 10s |
Contributor
Author
There was a problem hiding this comment.
It checks the status every 10s
Contributor
|
@yanmo96 Please also add MIT license into these files. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.