Add GoalStateV1 support #718
Conversation
|
This pull request fixes 1 alert when merging d8f3a71 into b464aa9 - view on LGTM.com fixed alerts:
|
| public class ProcessorChainManager implements IProcessorChainManager { | ||
| private static final Logger LOG = LoggerFactory.getLogger(ProcessorManager.class); | ||
|
|
There was a problem hiding this comment.
@DavidLiu506 Do we need these two functions ProcessorChainManager and ProcessorChainManagerV2? It seems like both functions has exactly same lines of code.
There was a problem hiding this comment.
Yes, AfterProcessor not same, it remove NeighborProcessor. If move RouterProcessor to DPM, add RouterProcessor to it.
| this.routerToDPMService.sendInternalRouterInfoToDPM(internalRouterInfo, networkConfiguration); | ||
| if (version.equals("101")) { | ||
| InternalRouterInfo internalRouterInfo = this.neutronRouterService.constructInternalRouterInfo(routerid, internalSubnetRoutingTableList); | ||
| System.out.println("version 101"); |
There was a problem hiding this comment.
@DavidLiu506 Please remove System.out.println here, use LOG instead.
|
@DavidLiu506 and @pkommoju can you test this branch in Jenkins? |
I will start a build shortly. |
Started. |
|
This pull request fixes 1 alert when merging f55e0fe into b464aa9 - view on LGTM.com fixed alerts:
|
xieus
left a comment
xieus
left a comment
There was a problem hiding this comment.
This is a really good change.
|
Relink to Issue #720 as it is a pending issue to be resolved later. |
4 participants
Add GoadState V1 support to Data Plane Manager, Port Manager and Route Manager and also enable GS version change in configuration file.