This repository was archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
[Tracing] Support Jaeger tracing in NCM and TC #707
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sent and programmed.
…t amount of ports
…lity to handle neighbor states
|
This pull request introduces 2 alerts when merging 4c99f65 into a843622 - view on LGTM.com new alerts:
|
This was referenced Dec 6, 2021
Contributor
|
@cj-chung Could you review this PR? |
Contributor
sure |
xieus
reviewed
Dec 10, 2021
Contributor
xieus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
...ger/src/main/java/com/futurewei/alcor/netwconfigmanager/client/gRPC/GoalStateClientImpl.java
Show resolved
Hide resolved
.../main/java/com/futurewei/alcor/netwconfigmanager/server/grpc/GoalStateProvisionerServer.java
Show resolved
Hide resolved
.../main/java/com/futurewei/alcor/netwconfigmanager/server/grpc/GoalStateProvisionerServer.java
Outdated
Show resolved
Hide resolved
xieus
approved these changes
Dec 10, 2021
Contributor
xieus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do:
Please refer to the following screenshot to get an idea of what to expect, when running Test Controller:

GoalState Pushdown process:
On-demand process:

The on-demand tracing was captured before merging #704 , after merging this PR, on-demand doesn't get triggered, as neigbhor states all push down before the pings.
Future improvements:
we suspect that this is because we are using different libraries here. In ACA, jaeger tracing was adding using the opentelemetry-cpp library, however, NCM uses the opentracing library. We suspect this mismatch is causing the ACA spans not connected with the NCM spans. We may want to change to opentelemetry library in Alcor later.