This repository was archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
[Netw Config Manager] Support coexist of gRPC and REST APIs #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pkommoju
commented
Dec 1, 2021
- Fix NMM to NCM gRPC problem so that NCM can operate on both gRPC and REST.
- Tested NMM to NCM REST API by registering one NCM through NMM.
- Tested NMM to NCM gRPC by creating a port through postman and verifying that NCM has recieved goal state.
- NOTE: the branch ncmgrpcrest and the pull request from it are buggy and and should be abandoned.
Add document about transactional semantics for Alcor Caches in general and spefically about Ignite Caches.
DavidLiu506
approved these changes
Dec 1, 2021
cj-chung
reviewed
Dec 2, 2021
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the swagger UI working now for NCM?
It does.
cj-chung
approved these changes
Dec 2, 2021
Contributor
cj-chung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
Contributor
Author
|
I have resolved the conflict on github, not sure if this worked or not, though. |
… ncmgrpcrest2 � Conflicts: � services/network_config_manager/src/main/java/com/futurewei/alcor/netwconfigmanager/NetworkConfigManagerApplication.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.