Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@pkommoju
Copy link
Contributor

@pkommoju pkommoju commented Dec 1, 2021

  • Fix NMM to NCM gRPC problem so that NCM can operate on both gRPC and REST.
  • Tested NMM to NCM REST API by registering one NCM through NMM.
  • Tested NMM to NCM gRPC by creating a port through postman and verifying that NCM has recieved goal state.
  • NOTE: the branch ncmgrpcrest and the pull request from it are buggy and and should be abandoned.

pkommoju and others added 30 commits May 12, 2021 11:34
Add document about transactional semantics for Alcor Caches in general
and spefically about Ignite Caches.
Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the swagger UI working now for NCM?

It does.

Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus added the bug Something isn't working label Dec 2, 2021
@xieus xieus added this to the Version 1.0.2021.12.30 milestone Dec 2, 2021
@xieus xieus changed the title Ncmgrpcrest2 [Netw Config Manager] Support coexist of gRPC and REST APIs Dec 2, 2021
@xieus
Copy link
Contributor

xieus commented Dec 2, 2021

@pkommoju We have one conflict with master after #703 is merged.

@pkommoju
Copy link
Contributor Author

pkommoju commented Dec 2, 2021

I have resolved the conflict on github, not sure if this worked or not, though.

… ncmgrpcrest2

� Conflicts:
�	services/network_config_manager/src/main/java/com/futurewei/alcor/netwconfigmanager/NetworkConfigManagerApplication.java
@xieus xieus merged commit 9288716 into futurewei-cloud:master Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants