This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Improve ip manger performance #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cj-chung
reviewed
Nov 8, 2021
Comment on lines
+199
to
+200
| public IpAddrAlloc allocateIpAddr(IpAddrRequest request) throws Exception { | ||
| IpAddrAlloc ipAddrAlloc = allocateIpAddrMethod(request); |
Contributor
There was a problem hiding this comment.
@DavidLiu506 Do we still need this function if we push all the process code into allocateIpAddrMethod?
Contributor
Author
There was a problem hiding this comment.
It called by other functions.
Comment on lines
89
to
98
| while(true) { | ||
| try { | ||
| IpAddrRequest result = restTemplate.postForObject(ipManagerUrl, request, IpAddrRequest.class); | ||
| verifyAllocatedIpAddr(result); | ||
| return result; | ||
| } catch (Exception e) { | ||
| // handle exception | ||
| if (++count == maxTries) throw e; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
@DavidLiu506 Should we use formal way to do the retry? such as RetryTemplate described in this link: https://www.baeldung.com/spring-retry
Contributor
Author
There was a problem hiding this comment.
Nice. Thank you!
Contributor
|
@DavidLiu506 Please add a brief description on the PR as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for ip manager performance improvement.
1 Transaction on ipAddrRangeCache (not include vpcIpRangeCache.get(vpcId)), this can reduce distribute lock and improve concurrent cache operation.
2 Add retry logic code in port manager is for cocurrent operate on create subnet and allocate ip.