Fix data plane manager to support goal state v2 #699
Conversation
|
This pull request introduces 3 alerts when merging 15a60e9 into d040632 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging dcbe16c into d040632 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 4b5428e into d040632 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 3f98c40 into d040632 - view on LGTM.com new alerts:
|
| } | ||
|
|
||
| boolean fastPath = portEntity.getFastPath() == null ? false : portEntity.getFastPath(); | ||
| //boolean fastPath = (portEntity.getFastPath() == null ? false : portEntity.getFastPath()); |
There was a problem hiding this comment.
@DavidLiu506 Please remove the commented out code.
| if (routingRules != null && routingRules.size() > 0) { | ||
| for (InternalRoutingRule routingRule: routingRules) { |
There was a problem hiding this comment.
@DavidLiu506 So we are allowing a RouterState with routing table but without routing rule entry? How ACA handle this scenario?
There was a problem hiding this comment.
ACA not process routing rule entry and put subnet state to local storage.
| //TODO: where does the hostDvrMacAddress come from ? | ||
| routerConfigBuilder.setHostDvrMacAddress(routerInfo.getRouterConfiguration().getHostDvrMac()); | ||
| routerConfigBuilder.setId(routerInfo.getRouterConfiguration().getId()); | ||
| routerConfigBuilder.setHostDvrMacAddress(HOST_DVR_MAC); |
There was a problem hiding this comment.
@DavidLiu506 Why not get hostDvrMac from routerInfo? if host_dvr_mac are different from router to router, we may need get host dvr mac from the routerInfo.
|
This pull request introduces 3 alerts when merging ac1cab5 into d040632 - view on LGTM.com new alerts:
|
|
LGTM if @DavidLiu506 resolves the comments. |
|
This pull request introduces 3 alerts when merging fd7b860 into d040632 - view on LGTM.com new alerts:
|
3 participants
Uh oh!
There was an error while loading. Please reload this page.