Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

[K8s Deployment] Improve deployment configuration and scripts #693

Merged
xieus merged 19 commits into from
Oct 22, 2021
Merged

[K8s Deployment] Improve deployment configuration and scripts #693

xieus merged 19 commits into from
Oct 22, 2021

Conversation

@yanmo96
Copy link
Contributor

@yanmo96 yanmo96 commented Oct 16, 2021 •
edited by xieus
Loading

This PR modifies the Alcor deployment scripts for k8s environment.

  • Deploy and activate the Ignite DB before starting others services.
  • Clean up Ignite k8s namespace as a part of k8s cluster cleanup process
  • Minor change of rewriting existing code to enhance the deployment process.
  • Remove legacy unused files related to the k8s deployment.

@yanmo96 yanmo96 requested review from cj-chung and xieus October 16, 2021 01:31
@yanmo96 yanmo96 self-assigned this Oct 16, 2021
@yanmo96
Copy link
Contributor Author

yanmo96 commented Oct 18, 2021

It will create ignite pods first, and set them to activate. Then create pods for other micro services.

cj-chung
cj-chung reviewed Oct 18, 2021
View reviewed changes
kubernetes/services/createYaml.sh Outdated
#cd apache-ignite/bin/
#./control.sh --activate

sleep 60s
Copy link
Contributor

@cj-chung cj-chung Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanmo96 Do we really need to wait 60s here?

Copy link
Contributor Author

@yanmo96 yanmo96 Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, no need to wait. Will remove it

cj-chung
cj-chung reviewed Oct 19, 2021
View reviewed changes
scripts/deployK8sClusterService.sh

cd /root
echo "***** Download and build images on each Node *****" 2>&1 | tee -a ~/alcor_logs/alcor.log
./deploy-alcor-nodes.sh update-alcor4.sh alcor-nodes-ips
Copy link
Contributor

@cj-chung cj-chung Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanmo96 If you put this sh file under script folder, these 3 files (deploy-alcor-nodes.sh, update-alcor4.sh and alcor-nodes-ips) also need to be included in this folder.

Copy link
Contributor Author

@yanmo96 yanmo96 Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do!

Copy link
Contributor

@cj-chung cj-chung Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alcor-nodes-ips is a little bit tricky, don't put our ips in the file and push to public repository.
I will recommend rewrite this line of code (line 29) to accept filename as parameters, so that we can flexibly run the script with 2 arguments (filename) - update-alcor.sh and alcor-nodes-ips in another folder with their path.

@xieus xieus added this to the Version 1.0.2021.12.30 milestone Oct 20, 2021
@xieus
Copy link
Contributor

xieus commented Oct 20, 2021

Looks pretty decent change. @yanmo96 please also check in new scripts if any, and update the description session about what has been proposed in this PR.

A good example, see PR #694 .

@yanmo96
Copy link
Contributor Author

yanmo96 commented Oct 21, 2021

Looks pretty decent change. @yanmo96 please also check in new scripts if any, and update the description session about what has been proposed in this PR.

A good example, see PR #694 .

Will do

@xieus
Copy link
Contributor

xieus commented Oct 22, 2021

This PR modifies the Alcor deployment scripts for k8s environment.

  • Deploy and activate the Ignite DB before starting others services.
  • Clean up Ignite k8s namespace as a part of k8s cluster cleanup process
  • Minor change of rewriting existing code to enhance the deployment process.
  • Remove legacy unused files related to the k8s deployment.

Thanks for adding the description. I update the description a bit. Please take a look @yanmo96

@xieus xieus changed the title New ignite deployment process [K8s Deployment] Improve deployment scripts Oct 22, 2021
@xieus xieus changed the title [K8s Deployment] Improve deployment scripts [K8s Deployment] Improve deployment configuration and scripts Oct 22, 2021
@xieus xieus merged commit 025cabf into futurewei-cloud:master Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cj-chung cj-chung cj-chung left review comments

@xieus xieus xieus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yanmo96 yanmo96

Labels

deployment and upgrade k8s

Projects

None yet

Milestone

Version 1.0.2022.01.30

Development

Successfully merging this pull request may close these issues.

3 participants

@yanmo96 @xieus @cj-chung