Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

Conversation

@zzxgzgz
Copy link
Contributor

@zzxgzgz zzxgzgz commented Jan 29, 2022

This PR includes the report of NCM Stress Test.

@zzxgzgz zzxgzgz self-assigned this Jan 29, 2022
Copy link
Contributor

@lfu-ps lfu-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 3rd file: where is the gray area? Is it 100% so covered by blue or red ?
  2. 4th file: in excel, there's a way to show numbers of the height (Y axis), it will add some level of clarity to the slope chart

@zzxgzgz
Copy link
Contributor Author

zzxgzgz commented Jan 31, 2022

  1. 3rd file: where is the gray area? Is it 100% so covered by blue or red ?
  2. 4th file: in excel, there's a way to show numbers of the height (Y axis), it will add some level of clarity to the slope chart
  1. The gray area is so small that it is not noticable in either of the graphs.
  2. I added the values for the Y axis, and changed the color of the 1 VPC testcases to green.

Copy link
Contributor

@lfu-ps lfu-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieus xieus added documentation Improvements or additions to documentation Perf labels Jan 31, 2022
Copy link

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzxgzgz @lfu-ps This is a great report overall. Left a few minor comments.

Copy link
Contributor Author

@zzxgzgz zzxgzgz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the issues brought up by reviewers.

Copy link

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first step to get a more high-performance NCM.

@xieus xieus merged commit 738dd98 into futurewei-cloud:master Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation Perf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants