This repository was archived by the owner on Mar 31, 2023. It is now read-only.
ACA task framework refactoring #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order to prevent deadlock
…essage_callback full capacity of receiving packets
This reverts commit 42716a1.
lfu-ps
reviewed
Jan 24, 2022
zzxgzgz
commented
Jan 25, 2022
| // Create a marl scheduler using all the logical processors available to the process. | ||
| // Bind this scheduler to the main thread so we can call marl::schedule() | ||
| marl::Scheduler::Config cfg_bind_hw_cores; | ||
| cfg_bind_hw_cores.setWorkerThreadCount(thread_pools_size * 2); |
Contributor
Author
There was a problem hiding this comment.
I made the worker thread count to be thread_pool_size * 2, instead of a fixed number.
lfu-ps
reviewed
Jan 25, 2022
lfu-ps
reviewed
Jan 25, 2022
…g flag to false in aca-machine-init
lfu-ps
changed the title
xieus
reviewed
Jan 27, 2022
| If you intent to store it somewhere, it is advised to make a copy of it. | ||
| */ | ||
| ACA_On_Demand_Engine::get_instance().parse_packet(in_port, pin.packet); | ||
| // ACA_On_Demand_Engine::get_instance().parse_packet(in_port, pin.packet); |
Contributor
There was a problem hiding this comment.
@zzxgzgz Any specific reason that the on demand engine is disabled here?
Contributor
Author
There was a problem hiding this comment.
@zzxgzgz Any specific reason that the on demand engine is disabled here?
This code path is not active now. The parse_packet will now be called in of_controller.cpp, inside of the message_callback function, when there is a packet_in.
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Development/testing is still ongoing, new findings/test results will be posted when available.