-
Notifications
You must be signed in to change notification settings - Fork 29
Add listeners for mulitcast and unicast consumers #268
Conversation
|
Thank you for submitting this PR @lly00, could you please share the test results, if any, with the community? That will help us a lot in the reviewing process. Thank you. |
OK, but what kind of test results do we need? Are the test results of gtests or just of pulsar client? |
The gtest results will be great. Also, I noticed that the Thank you. |
add mq test for both multicast and unicast
|
@zzxgzgz We have add some test cases for pulsar consumer, which send a goalstate to create a port. The pulsar consumer is able to receive GoalState and update GoalState successfully. However, it does not support goalstateV2 currently. |
Thank you for your update. For this PR, adding support to GoalState(V1) should be good enough. Can you please provide some kind of test result of the GoalState, just like the screenshot you provided for the GoalStateV2 tests? So that we can confirm that the GoalState was successfully sent to ACA via this pulsar channel. Thank you. |
Consumer now can update GoalStateV2 messages
fix pulsar producer orderingKey bugs
zzxgzgz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



This is the PR for pulsar client implementation on aca based on the previous designs.