This repository was archived by the owner on Mar 31, 2023. It is now read-only.
Routing rule gsv2 #267
Merged
Routing rule gsv2 #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Merged code from upstream master. |
Contributor
Author
|
Will create an issue to track the testing of this item. |
lfu-ps
reviewed
Feb 1, 2022
| auto remote_host_ip = ""; | ||
| ulong culminative_dataplane_programming_time = 0; | ||
| for (auto each_neighbor : parsed_struct.neighbor_states()) { | ||
| NeighborConfiguration current_NeighborConfiguration1 = |
Contributor
Author
There was a problem hiding this comment.
why 'Configuration1' ?
Just following the variable names in the V1 version.
lfu-ps
approved these changes
Feb 1, 2022
xieus
approved these changes
Feb 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do:
This PR implemented the routing rule update with GoalStateV2.
NOTE:
Please don't merge it until it is tested.