Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for wrong page being displayed sometimes. #914

Merged
merged 4 commits into from
Jun 5, 2019

Conversation

tushar9989
Copy link
Contributor

@tushar9989 tushar9989 commented Feb 10, 2019

@tushar9989 tushar9989 closed this Feb 10, 2019
@tushar9989 tushar9989 reopened this Feb 11, 2019
@fchasen
Copy link
Contributor

fchasen commented Mar 8, 2019

Thanks for this. I'll clone this and give it a try

@onedevlad
Copy link

onedevlad commented May 21, 2019

Hey, is this fix going to get merged?

@fchasen fchasen merged commit 98f9ad7 into futurepress:master Jun 5, 2019
@scott-engemann
Copy link
Contributor

Any anyone else encountered errors since this fix? Version 0.3.83 seems to be the last stable version. I'm attempting to load an Epub to a cover page via epubCIFrange (epubcfi(/6/2[cover]!/4)) and when line 590 is called (range.setEnd), no such method exists on the range object. I'm getting the error

contents.js:593 setting end offset to start container length failed DOMException: Failed to execute 'setEnd' on 'Range': There is no child at offset 19.

There has been at least one other error reported similar to this: #895 (comment)

@tushar9989
Copy link
Contributor Author

This is just reported in the console, it is wrapped with a try catch.

@scott-engemann
Copy link
Contributor

When this error occurs, the book no longer navigates. This is more than just a "reported in the console" thing.

@tushar9989
Copy link
Contributor Author

Can you share the book so that I can look into it.

@qtv100291
Copy link

Still stuck on this issue, after changing font size by using rendition.themes.fontSize, rendition.display sometimes doesn't show right location of a cfi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants