Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use querySelector instead of getElementById on manifest node #826

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Use querySelector instead of getElementById on manifest node #826

merged 1 commit into from
Sep 20, 2018

Conversation

christianmemije
Copy link
Contributor

getElementById is a Document method. So instead, use querySelector on the manifest node. Thanks for this awesome project. 🥇

@christianmemije christianmemije mentioned this pull request Sep 19, 2018
Closed
@fchasen fchasen merged commit edf3f2e into futurepress:master Sep 20, 2018
@fchasen
Copy link
Contributor

fchasen commented Sep 20, 2018

Great, thanks -- will go out in the next release

@snyk-bot snyk-bot mentioned this pull request Jun 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianmemije @fchasen