Allow span in toc nav items
#1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://www.w3.org/publishing/epub32/epub-packages.html#sec-package-nav-def-model: "A child `a` element describes the target that the link points to, while a `span` element serves as a heading for breaking down lists into distinct groups (for example, a large list of illustrations can be segmented into several lists, one for each chapter)."
|
🎉 🎉 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://www.w3.org/publishing/epub32/epub-packages.html#sec-package-nav-def-model:
Test case courtesy of @kianmeng: no_nested_submenu_in_toc.zip
Evaluating
book.navigation.tocwithout this fix: toc ignores all items marked withspanand their subitems.[{"id":"intro.xhtml","href":"intro.xhtml","label":"Introduction","subitems":[]}]With this fix: toc correctly contains all items.
[{"id":"intro.xhtml","href":"intro.xhtml","label":"Introduction","subitems":[]},{"id":"","href":"","label":"Languages","subitems":[{"id":"intro.xhtml","href":"intro.xhtml","label":"Introduction","subitems":[],"parent":""},{"id":"about.xhtml","href":"about.xhtml","label":"About this book","subitems":[],"parent":""}]}]