indexer stability: disable object history (MystenLabs#10961)

## Description object history takes a lot of storage and is not being used ## Test Plan Test locally to make sure - all other workflows can work as expected - no object history table / data will be created
futureengco · Apr 18, 2023 · 2829930 · 2829930
1 parent edcdb88
commit 2829930
Show file tree

Hide file tree

Showing 2 changed files with 77 additions and 76 deletions.
diff --git a/crates/sui-indexer/migrations/2022-12-01-034426_objects/down.sql b/crates/sui-indexer/migrations/2022-12-01-034426_objects/down.sql
@@ -1,5 +1,5 @@
 DROP TABLE IF EXISTS objects;
-DROP TABLE IF EXISTS objects_history;
+-- DROP TABLE IF EXISTS objects_history;
 
 DROP TYPE IF EXISTS owner_type;
 DROP TYPE IF EXISTS bcs_bytes;

diff --git a/crates/sui-indexer/migrations/2022-12-01-034426_objects/up.sql b/crates/sui-indexer/migrations/2022-12-01-034426_objects/up.sql
@@ -39,82 +39,83 @@ CREATE TABLE objects
 CREATE INDEX objects_owner_address ON objects (owner_type, owner_address);
 CREATE INDEX objects_tx_digest ON objects (previous_transaction);
 
-CREATE TABLE objects_history
-(
-    epoch                  BIGINT        NOT NULL,
-    checkpoint             BIGINT        NOT NULL,
-    object_id              address       NOT NULL,
-    version                BIGINT        NOT NULL,
-    object_digest          base58digest  NOT NULL,
-    owner_type             owner_type    NOT NULL,
-    owner_address          address,
-    old_owner_type         owner_type,
-    old_owner_address      address,
-    initial_shared_version BIGINT,
-    previous_transaction   base58digest  NOT NULL,
-    object_type            VARCHAR       NOT NULL,
-    object_status          object_status NOT NULL,
-    has_public_transfer    BOOLEAN       NOT NULL,
-    storage_rebate         BIGINT        NOT NULL,
-    bcs                    bcs_bytes[]   NOT NULL,
-    CONSTRAINT objects_history_pk PRIMARY KEY (object_id, version, checkpoint)
-) PARTITION BY RANGE (checkpoint);
-CREATE INDEX objects_history_checkpoint_index ON objects_history (checkpoint);
-CREATE INDEX objects_history_id_version_index ON objects_history (object_id, version);
-CREATE INDEX objects_history_owner_index ON objects_history (owner_type, owner_address);
-CREATE INDEX objects_history_old_owner_index ON objects_history (old_owner_type, old_owner_address);
--- fast-path partition for the most recent objects before checkpoint, range is half-open.
--- partition name need to match regex of '.*(_partition_)\d+'.
-CREATE TABLE objects_history_fast_path_partition_0 PARTITION OF objects_history FOR VALUES FROM (-1) TO (0);
-CREATE TABLE objects_history_partition_0 PARTITION OF objects_history FOR VALUES FROM (0) TO (MAXVALUE);
+-- NOTE(gegaowp): remove object history so that it will not be created over DB reset / migration run.
+-- CREATE TABLE objects_history
+-- (
+--     epoch                  BIGINT        NOT NULL,
+--     checkpoint             BIGINT        NOT NULL,
+--     object_id              address       NOT NULL,
+--     version                BIGINT        NOT NULL,
+--     object_digest          base58digest  NOT NULL,
+--     owner_type             owner_type    NOT NULL,
+--     owner_address          address,
+--     old_owner_type         owner_type,
+--     old_owner_address      address,
+--     initial_shared_version BIGINT,
+--     previous_transaction   base58digest  NOT NULL,
+--     object_type            VARCHAR       NOT NULL,
+--     object_status          object_status NOT NULL,
+--     has_public_transfer    BOOLEAN       NOT NULL,
+--     storage_rebate         BIGINT        NOT NULL,
+--     bcs                    bcs_bytes[]   NOT NULL,
+--     CONSTRAINT objects_history_pk PRIMARY KEY (object_id, version, checkpoint)
+-- ) PARTITION BY RANGE (checkpoint);
+-- CREATE INDEX objects_history_checkpoint_index ON objects_history (checkpoint);
+-- CREATE INDEX objects_history_id_version_index ON objects_history (object_id, version);
+-- CREATE INDEX objects_history_owner_index ON objects_history (owner_type, owner_address);
+-- CREATE INDEX objects_history_old_owner_index ON objects_history (old_owner_type, old_owner_address);
+-- -- fast-path partition for the most recent objects before checkpoint, range is half-open.
+-- -- partition name need to match regex of '.*(_partition_)\d+'.
+-- CREATE TABLE objects_history_fast_path_partition_0 PARTITION OF objects_history FOR VALUES FROM (-1) TO (0);
+-- CREATE TABLE objects_history_partition_0 PARTITION OF objects_history FOR VALUES FROM (0) TO (MAXVALUE);
 
-CREATE OR REPLACE FUNCTION objects_modified_func() RETURNS TRIGGER AS
-$body$
-BEGIN
-    IF (TG_OP = 'INSERT') THEN
-        INSERT INTO objects_history
-        VALUES (NEW.epoch, NEW.checkpoint, NEW.object_id, NEW.version, NEW.object_digest, NEW.owner_type,
-                NEW.owner_address, NULL, NULL,
-                NEW.initial_shared_version,
-                NEW.previous_transaction, NEW.object_type, NEW.object_status, NEW.has_public_transfer,
-                NEW.storage_rebate, NEW.bcs);
-        RETURN NEW;
-    ELSEIF (TG_OP = 'UPDATE') THEN
-        INSERT INTO objects_history
-        VALUES (NEW.epoch, NEW.checkpoint, NEW.object_id, NEW.version, NEW.object_digest, NEW.owner_type,
-                NEW.owner_address, OLD.owner_type, OLD.owner_address,
-                NEW.initial_shared_version,
-                NEW.previous_transaction, NEW.object_type, NEW.object_status, NEW.has_public_transfer,
-                NEW.storage_rebate, NEW.bcs);
-        -- MUSTFIX(gegaowp): we cannot update checkpoint in-place, b/c checkpoint is a partition key,
-        -- we need to prune old data in this partition periodically, like pruning old epochs upon new epoch.
-        RETURN NEW;
-    ELSIF (TG_OP = 'DELETE') THEN
-        -- object deleted from the main table, archive the history for that object
-        DELETE FROM objects_history WHERE object_id = old.object_id;
-        RETURN OLD;
-    ELSE
-        RAISE WARNING '[OBJECTS_MODIFIED_FUNC] - Other action occurred: %, at %',TG_OP,NOW();
-        RETURN NULL;
-    END IF;
+-- CREATE OR REPLACE FUNCTION objects_modified_func() RETURNS TRIGGER AS
+-- $body$
+-- BEGIN
+--     IF (TG_OP = 'INSERT') THEN
+--         INSERT INTO objects_history
+--         VALUES (NEW.epoch, NEW.checkpoint, NEW.object_id, NEW.version, NEW.object_digest, NEW.owner_type,
+--                 NEW.owner_address, NULL, NULL,
+--                 NEW.initial_shared_version,
+--                 NEW.previous_transaction, NEW.object_type, NEW.object_status, NEW.has_public_transfer,
+--                 NEW.storage_rebate, NEW.bcs);
+--         RETURN NEW;
+--     ELSEIF (TG_OP = 'UPDATE') THEN
+--         INSERT INTO objects_history
+--         VALUES (NEW.epoch, NEW.checkpoint, NEW.object_id, NEW.version, NEW.object_digest, NEW.owner_type,
+--                 NEW.owner_address, OLD.owner_type, OLD.owner_address,
+--                 NEW.initial_shared_version,
+--                 NEW.previous_transaction, NEW.object_type, NEW.object_status, NEW.has_public_transfer,
+--                 NEW.storage_rebate, NEW.bcs);
+--         -- MUSTFIX(gegaowp): we cannot update checkpoint in-place, b/c checkpoint is a partition key,
+--         -- we need to prune old data in this partition periodically, like pruning old epochs upon new epoch.
+--         RETURN NEW;
+--     ELSIF (TG_OP = 'DELETE') THEN
+--         -- object deleted from the main table, archive the history for that object
+--         DELETE FROM objects_history WHERE object_id = old.object_id;
+--         RETURN OLD;
+--     ELSE
+--         RAISE WARNING '[OBJECTS_MODIFIED_FUNC] - Other action occurred: %, at %',TG_OP,NOW();
+--         RETURN NULL;
+--     END IF;
 
-EXCEPTION
-    WHEN data_exception THEN
-        RAISE WARNING '[OBJECTS_MODIFIED_FUNC] - UDF ERROR [DATA EXCEPTION] - SQLSTATE: %, SQLERRM: %',SQLSTATE,SQLERRM;
-        RETURN NULL;
-    WHEN unique_violation THEN
-        RAISE WARNING '[OBJECTS_MODIFIED_FUNC] - UDF ERROR [UNIQUE] - SQLSTATE: %, SQLERRM: %',SQLSTATE,SQLERRM;
-        RETURN NULL;
-    WHEN OTHERS THEN
-        RAISE WARNING '[OBJECTS_MODIFIED_FUNC] - UDF ERROR [OTHER] - SQLSTATE: %, SQLERRM: %',SQLSTATE,SQLERRM;
-        RETURN NULL;
-END;
-$body$
-    LANGUAGE plpgsql;
+-- EXCEPTION
+--     WHEN data_exception THEN
+--         RAISE WARNING '[OBJECTS_MODIFIED_FUNC] - UDF ERROR [DATA EXCEPTION] - SQLSTATE: %, SQLERRM: %',SQLSTATE,SQLERRM;
+--         RETURN NULL;
+--     WHEN unique_violation THEN
+--         RAISE WARNING '[OBJECTS_MODIFIED_FUNC] - UDF ERROR [UNIQUE] - SQLSTATE: %, SQLERRM: %',SQLSTATE,SQLERRM;
+--         RETURN NULL;
+--     WHEN OTHERS THEN
+--         RAISE WARNING '[OBJECTS_MODIFIED_FUNC] - UDF ERROR [OTHER] - SQLSTATE: %, SQLERRM: %',SQLSTATE,SQLERRM;
+--         RETURN NULL;
+-- END;
+-- $body$
+--     LANGUAGE plpgsql;
 
-CREATE TRIGGER objects_history
-    AFTER INSERT OR UPDATE OR DELETE
-    ON objects
-    FOR EACH ROW
-EXECUTE PROCEDURE objects_modified_func();
+-- CREATE TRIGGER objects_history
+--     AFTER INSERT OR UPDATE OR DELETE
+--     ON objects
+--     FOR EACH ROW
+-- EXECUTE PROCEDURE objects_modified_func();