PR de correção. Não precisa mergeear #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtros em construção
Ajustando css do carrinho
acho que ta combinando
pedro-severo
commented
Jun 3, 2020
Comment on lines
+58
to
+65
|
|
||
| const MainContainer = styled.div` | ||
| display: grid; | ||
| grid-template-columns: 1fr 3fr 1fr; | ||
| `; | ||
|
|
||
|
|
||
|
|
Author
There was a problem hiding this comment.
Pro código do componente não ficar tão grande, vcs podem isolar suas constantes do styled-componente em um arquivo separado, chamado styled.js, fazer toda a configuração CSS lá e apenas importar as constantes pro arquivo do componente.
pedro-severo
commented
Jun 3, 2020
Comment on lines
+7
to
+19
| const produtos = [ | ||
| { | ||
| id: 1, | ||
| nome: "produto 1", | ||
| valor: 10, | ||
| imgUrl: "https://picsum.photos/200/200?a=1", | ||
| }, | ||
| { | ||
| id: 2, | ||
| nome: "produto 2", | ||
| valor: 20, | ||
| imgUrl: "https://picsum.photos/200/200?a=2", | ||
| }, |
Author
There was a problem hiding this comment.
Boooa! Excelente prática isolar o array do estado fora do componente!
pedro-severo
commented
Jun 3, 2020
Comment on lines
+3
to
+5
| import Filter from "./components/Filter/Filter"; | ||
| import Carrinho from "./components/Carrinho/Carrinho"; | ||
| import GridProdutos from "./components/GridProdutos/GridProdutos"; |
Author
|
Querida(o)s, fiz alguns comentários ao longo do código... deem uma olhada. Além disso, o Darvas disponibilizou ontem (02 de junho) o gabarito do exercício em vídeo (thinking in react). Deem uma olhada lá também. Vcs estão de parabéns pela entrega!! Continuem assim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://mello-labe-commerce11.surge.sh/