Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -wp-ignore-inactive flag which ignores inactive plugin or themes #974

Merged
merged 15 commits into from
May 29, 2020
Merged

add -wp-ignore-inactive flag which ignores inactive plugin or themes #974

merged 15 commits into from
May 29, 2020

Conversation

kazuminn
Copy link
Contributor

@kazuminn kazuminn commented May 3, 2020

What did you implement:

add -wp-ignore-inactive flag which ignores inactive plugin or themes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Move wordpress on linux. Insert the plugin containing the vulnerability and make it active. So run it once and make sure it is detected. Then run it inactive to make sure it is not detected.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kazuminn kazuminn changed the title [WIP] add a flag ignore inactive plugin or themes such as -wp-ignore-inactive flag add -wp-ignore-inactive flag which is ignore inactive plugin or themes May 4, 2020
@kazuminn
Copy link
Contributor Author

@tomoyamachi I actually tested it with wp in action.

I have a conflict, but I don't know the correct way to write it. Could you fix it?

@tomoyamachi
Copy link
Contributor

Go Module is (sometimes) smart. It is easy.

  1. git fetch (upstream or origin) master
  2. git merge (upstream or origin)/master
  3. delete conflict lines from go.mod and go.sum
  4. go mod tidy
  5. resolve merge conflict

https://stackoverflow.com/questions/16955980/git-merge-master-into-feature-branch

@kazuminn
Copy link
Contributor Author

@tomoyamachi I fixed conflict . and pass ci.

@kotakanbe kotakanbe changed the title add -wp-ignore-inactive flag which is ignore inactive plugin or themes add -wp-ignore-inactive flag which ignores inactive plugin or themes May 27, 2020
@kotakanbe
Copy link
Member

LGTM

@kotakanbe kotakanbe merged commit 8d5ea98 into future-architect:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants