-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -wp-ignore-inactive flag which ignores inactive plugin or themes #974
Merged
kotakanbe
merged 15 commits into
future-architect:master
from
kazuminn:option-wp-ignore-inactive
May 29, 2020
Merged
add -wp-ignore-inactive flag which ignores inactive plugin or themes #974
kotakanbe
merged 15 commits into
future-architect:master
from
kazuminn:option-wp-ignore-inactive
May 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomoyamachi
reviewed
May 13, 2020
@tomoyamachi I actually tested it with wp in action. I have a conflict, but I don't know the correct way to write it. Could you fix it? |
Go Module is (sometimes) smart. It is easy.
https://stackoverflow.com/questions/16955980/git-merge-master-into-feature-branch |
@tomoyamachi I fixed conflict . and pass ci. |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
add -wp-ignore-inactive flag which ignores inactive plugin or themes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Move wordpress on linux. Insert the plugin containing the vulnerability and make it active. So run it once and make sure it is detected. Then run it inactive to make sure it is not detected.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES