Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dependency Check v5.3.0 #936

Merged

Conversation

ishiDACo
Copy link
Contributor

What did you implement:

Fixes #935

Vuls's Dependency Check parser supports for latest Dependency Check.

Older Dependency Check does not work due to NVD XML feed retirement.
Newer Dependency Check works fine.

But, Vuls supports only older versions of Dependency Check XML schema.

Latest Dependency Check schema is changed from older version to dependency-check.2.3.xsd.
ref https://github.com/jeremylong/DependencyCheck/tree/master/core/src/main/resources/schema

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run OWASP Dependency Check CLI v5.3.0 with resources include vuln.

dependency-check.sh --format XML --scan ~/DependencyCheck-5.3.0/core/src/test/resources --prettyPrint --project localhost
dependency-check.sh --format HTML --scan ~/DependencyCheck-5.3.0/core/src/test/resources --project localhost

OWASP Dependency Check output: dependency-check-report.xml and dependency-check-report.html

Vuls scan result: localhost.json
Vuls report full text: localhost_full.txt

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe merged commit fe3f1b9 into future-architect:master Feb 27, 2020
@kotakanbe
Copy link
Member

Many Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support latest Dependency Check
2 participants