Skip to content

Conversation

shigechika
Copy link
Contributor

@shigechika shigechika commented Oct 17, 2019

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

vuls scan failed that wordpress site includes poor theme/plugin.
when wp-cli output stderr, vuls scan can't get only json messages.

Fixes #825

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I checked to ignore the following messages.

Unable to open /SITE1/wordpress/wp-content/wflogs/ips.php for reading and writing.
PHP Warning:  call_user_func_array() expects parameter 1 to be a valid callback, function 'goyahso_change_post_object' not found or invalid function name in /SITE1/wordpress/wp-includes/class-wp-hook.php on line 286
Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'goyahso_change_post_object' not found or invalid function name in /SITE1/wordpress/wp-includes/class-wp-hook.php on line 286
PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /SITE2/wordpress/wp-includes/pomo/plural-forms.php on line 210
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /SITE2/wordpress/wp-includes/pomo/plural-forms.php on line 210

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@kotakanbe kotakanbe merged commit 69214e0 into future-architect:master Nov 1, 2019
@kotakanbe
Copy link
Member

Thanks!

kotakanbe added a commit that referenced this pull request Nov 25, 2019
* fix(scan): ignore wp-cli stderr messages (#825) (#915)

* refactor

* feat(report): fill Red Hat CVE data for all distros

* fix lint err

* fix cve judgment (#921)
kotakanbe added a commit that referenced this pull request Nov 26, 2019
* fix(scan): ignore wp-cli stderr messages (#825) (#915)

* fix(scan): warn if unable to get ip address on the scan tareget server

* fix test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to scan WordPress's poor theme/plugin
2 participants