Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): fix cvedb-url, add -cvedb-type=http #734

Merged
merged 7 commits into from
Nov 16, 2018
Merged

Conversation

kotakanbe
Copy link
Member

@kotakanbe kotakanbe commented Nov 14, 2018

What did you implement:

If you use go-cve-dictionary, goval-dictionary, gost, go-exploitdb as http server mode, type of each dictionary have to be defined http

config.toml

[cveDict]
type = "http"
url = "http://localhost:1323"

[ovalDict]
type = "http"
url = "http://localhost:1324"

[gost]
type = "http"
url = "http://localhost:1325"

[exploit]
type = "http"
url = "http://localhost:1326"

also add http to command line args.

Fixes #721

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe changed the title [WIP]fix(report): fix cvedb-url, add -cvedb-type=http fix(report): fix cvedb-url, add -cvedb-type=http Nov 16, 2018
@kotakanbe kotakanbe mentioned this pull request Nov 16, 2018
@kotakanbe kotakanbe merged commit 7585f9d into master Nov 16, 2018
@kotakanbe kotakanbe deleted the fix-dict-server branch January 24, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vuls -cvedb-url command line option not working
1 participant