Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): generate report even if some scan-err-jsons are included #685 #686

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

kotakanbe
Copy link
Member

@kotakanbe kotakanbe commented Jul 24, 2018

What did you implement:

Fixes #685

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • prepare 2 jsons. one includes err.
  • report
  • generate a report of no-err-json. (don't stop halfway)

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe merged commit ea800e0 into master Jul 24, 2018
kotakanbe added a commit that referenced this pull request Jul 24, 2018
* master:
  fix(report): generate report even if some scan-err-jsons are included #685 (#686)
  Change GitHub templates
@kotakanbe kotakanbe deleted the continue-reporting-scan-err branch August 27, 2018 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Servers unable to be scanned crash 'vuls report'
1 participant