LXC container support without LXD #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mai346 Can you fix the README too? |
|
tested on CentOS 6.9 + lxc-1.0.11-1 (Fedora EPEL) |
mai346
force-pushed
the
AddSupportLXC
branch
from
17cc891 to
53d4e9d
Compare
|
Many Thanks! |
kotakanbe
added a commit
that referenced
this pull request
Jan 10, 2018
* master: Fixed panic occurred when blank line continued in changelog (#569) Fixed Typo (#574) fix typo(BackSpace) in README.ja.md (#576) Fix a bug of sending to closed socket while oval access via HTTP #578 (#579) fix typo in reports/s3.go (#573) LXC container support without LXD (#552) Support Amazon Linux2 (#562) Fix #548 and #557 - RHEL's Fast Scan no longer required internet connection and root privilege (#559) Change error handling of "Reboot Required" detection (#556) Fix some RPM related commands failed in the container (#554) travis: update go version (#555) Add more kernel related packages (Fix #541) (#551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
LXC container support without LXD
How did you implement it:
Container type "lxc" has been added.
We assume an environment where LXD is not installed, so use "lxc-ls" command and "lxc-attach" command.
If old style settings are left in the container, warnings are inherently output to STDERR.
STDERR is redirected to "/dev/null" because it mixes with STDOUT during parsing.
Just like any other container (Docker and LXD), you need to connect to the host as root or a user with the required privileges.
How can we verify it:
It is possible to test in environments where "lxc-ls" and "lxc-attach" can be used.
I tested on Proxmox VE 5.1 (Debian 9 based virtualization host).
Todos:
You don't have to satisfy all of the following.
make fmtmake testIs this ready for review?: YES
Is it a breaking change?: NO