Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace strings.HasPrefix with strings.Index for SuSE scanner #546

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

flaviu-toader
Copy link
Contributor

@flaviu-toader flaviu-toader commented Nov 20, 2017

What did you implement:

Closes #515

How did you implement it:

I replaced strings.HasPrefix call with strings.Index call for the lines returned by zypper q -lu as it seems that output contains some extra bytes, confusing HasPrefix.

How can we verify it:

I verified it by scanning a SLES 11 SP4 box.

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: yes
Is it a breaking change?: NO

@kotakanbe kotakanbe merged commit d00e912 into future-architect:master Nov 21, 2017
@kotakanbe
Copy link
Member

Many Thanks!!

kotakanbe added a commit that referenced this pull request Dec 4, 2017
* master:
  Update README (#547)
  Support Alpine Linux #194 (#545)
  Replace strings.HasPrefix with strings.Index for SuSE scanner (#546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to scan updatable packages: zypper -q lu Unknown format
2 participants