Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector/github): Enhance the dependency graph API call on the big repository #1681

Merged
merged 3 commits into from
May 26, 2023

Conversation

kl-sinclair
Copy link
Collaborator

@kl-sinclair kl-sinclair commented May 24, 2023

What did you implement:

I have made enhancements to the timeout retry mechanism in the Dependency Graph API by reducing the number of dependencies to be fetched per retry.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

$ vuls report -to-localfile -format-cyclonedx-json
or 
$ vuls report -to-localfile -format-cyclonedx-xml

retry with reduced number of dependencies on timeout

スクリーンショット 2023-05-24 18 42 43

another error of Github timeout

スクリーンショット 2023-05-24 18 31 44

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@kl-sinclair kl-sinclair marked this pull request as ready for review May 24, 2023 10:07
@kl-sinclair kl-sinclair requested a review from kotakanbe May 24, 2023 10:08
@kl-sinclair kl-sinclair self-assigned this May 24, 2023
@kotakanbe kotakanbe merged commit 6271ec5 into future-architect:master May 26, 2023
@kl-sinclair kl-sinclair deleted the gsa-deps-enhance branch May 26, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants