Skip to content

fix(oval/suse): use def.Advisory.Cves[0].CveID instead of def.Title #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Feb 17, 2022

What did you implement:

In goval-dictionary, when fetching with --no-details, the title will be "".
In vuls, there was a bug in the title-dependent part.
Fix this.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

$ goval-dictionary fetch suse --suse-type opensuse-leap 15.3 --no-details
$ vuls report
[Feb 17 10:50:39]  INFO [localhost] vuls-v0.19.4-build-20220217_104818_716bf30
[Feb 17 10:50:39]  INFO [localhost] Validating config...
[Feb 17 10:50:39]  INFO [localhost] cveDict.type=sqlite3, cveDict.url=, cveDict.SQLite3Path=/usr/share/vuls-data/cve.sqlite3
[Feb 17 10:50:39]  INFO [localhost] ovalDict.type=sqlite3, ovalDict.url=, ovalDict.SQLite3Path=/usr/share/vuls-data/oval.sqlite3
[Feb 17 10:50:39]  INFO [localhost] gost.type=sqlite3, gost.url=, gost.SQLite3Path=/usr/share/vuls-data/gost.sqlite3
[Feb 17 10:50:39]  INFO [localhost] exploit.type=sqlite3, exploit.url=, exploit.SQLite3Path=/usr/share/vuls-data/go-exploitdb.sqlite3
[Feb 17 10:50:39]  INFO [localhost] metasploit.type=sqlite3, metasploit.url=, metasploit.SQLite3Path=/usr/share/vuls-data/go-msfdb.sqlite3
[Feb 17 10:50:39]  INFO [localhost] kevuln.type=sqlite3, kevuln.url=, kevuln.SQLite3Path=/usr/share/vuls-data/go-kev.sqlite3
[Feb 17 10:50:39]  INFO [localhost] Loaded: /home/mainek00n/github/github.com/MaineK00n/vuls/results/2022-02-17T10:50:28+09:00
[Feb 17 10:50:39]  INFO [localhost] OVAL opensuse.leap 15.3 found. defs: 1333
[Feb 17 10:50:39]  INFO [localhost] OVAL opensuse.leap 15.3 is fresh. lastModified: 2022-02-17T10:20:02+09:00
[Feb 17 10:50:39]  INFO [localhost] vuls-target: 11 CVEs are detected with OVAL
[Feb 17 10:50:39]  INFO [localhost] vuls-target: 0 unfixed CVEs are detected with gost
[Feb 17 10:50:39]  INFO [localhost] vuls-target: 0 CVEs are detected with CPE
[Feb 17 10:50:39]  INFO [localhost] vuls-target: 0 PoC are detected
[Feb 17 10:50:39]  INFO [localhost] vuls-target: 0 exploits are detected
[Feb 17 10:50:39]  INFO [localhost] vuls-target: total 11 CVEs detected
[Feb 17 10:50:39]  INFO [localhost] vuls-target: 0 CVEs filtered by --confidence-over=80
vuls-target (opensuse.leap15.3)
===============================
Total: 11 (Critical:3 High:5 Medium:3 Low:0 ?:0)
11/11 Fixed, 3 poc, 0 exploits, cisa: 0, uscert: 0, jpcert: 0 alerts
137 installed

+----------------+------+--------+-----+-----------+---------+-------------------------------------------------+
|     CVE-ID     | CVSS | ATTACK | POC |   ALERT   |  FIXED  |                       NVD                       |
+----------------+------+--------+-----+-----------+---------+-------------------------------------------------+
| CVE-2021-44142 |  9.9 |  AV:N  |     |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2021-44142 |
| CVE-2022-23218 |  9.8 |  AV:L  | POC |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2022-23218 |
| CVE-2022-23219 |  9.8 |  AV:L  | POC |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2022-23219 |
| CVE-2022-0336  |  8.8 |  AV:N  |     |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2022-0336  |
| CVE-2021-3999  |  8.1 |  AV:L  |     |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2021-3999  |
| CVE-2020-27840 |  7.5 |  AV:N  |     |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2020-27840 |
| CVE-2021-20277 |  7.5 |  AV:N  |     |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2021-20277 |
| CVE-2021-36222 |  7.5 |  AV:N  |     |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2021-36222 |
| CVE-2021-20316 |  5.9 |  AV:N  |     |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2021-20316 |
| CVE-2021-44141 |  5.0 |  AV:N  |     |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2021-44141 |
| CVE-2021-43566 |  4.2 |  AV:N  | POC |           |   fixed | https://nvd.nist.gov/vuln/detail/CVE-2021-43566 |
+----------------+------+--------+-----+-----------+---------+-------------------------------------------------+

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Feb 17, 2022
@kotakanbe kotakanbe merged commit 7750347 into master Feb 17, 2022
@kotakanbe kotakanbe deleted the MaineK00n/fix-suse-no-details branch February 17, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants