-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(detector): standardize db.NewDB to db.CloseDB #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8683981
to
1e2f542
Compare
00a592b
to
fb9c853
Compare
kotakanbe
requested changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one point that could be a nil pointer, so please fix it.
fb9c853
to
34e7a89
Compare
kotakanbe
approved these changes
Feb 18, 2022
Confirmed that make diff was successful. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
db.Close(), which was the cause of this issue(#1281), was handled differently in OVAL, gost, exploitdb, metasploitdb, and kevuln.
This time, we will refactor it so that all of them use the same method to get the client and close the DB.
Also, the method to determine whether it is a DB or HTTP is based on whether the driver, which is the minimum data, is nil or not. In addition, I decided to have only the URL to the dictionary (baseURL) so that it does not need to be as large as the config.
Fixes #1121
Duplicate PR #1272
In addition to refactoring the client around, I incorporated the following issue and PR content.
When there is no config.toml (configPath is ""), read environment variables and enable reporting.
Type of change
How Has This Been Tested?
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Reference