Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for missing files in the results or results directory #1206

Merged
merged 2 commits into from
Apr 4, 2021

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

In the initial state, there are no results under the integration directory, and make diff will generate an error. Therefore, we need to add directory and file checks.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I deleted the integration/results file and ran make diff, and confirmed that it succeeded.

$ rm -rf integration/results/
$ make diff

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Apr 3, 2021
@MaineK00n MaineK00n requested a review from kotakanbe April 3, 2021 21:37
Copy link
Member

@kotakanbe kotakanbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kotakanbe kotakanbe dismissed their stale review April 3, 2021 22:24

mistake

@MaineK00n MaineK00n requested a review from kotakanbe April 4, 2021 13:07
@kotakanbe kotakanbe merged commit 183fdcb into future-architect:master Apr 4, 2021
@kotakanbe
Copy link
Member

Many Thanks :)

@MaineK00n MaineK00n deleted the fix-make-diff branch July 26, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants