Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trivy-to-vuls): converts even if null vulnerabilities #1201

Merged

Conversation

tomoyamachi
Copy link
Contributor

@tomoyamachi tomoyamachi commented Mar 22, 2021

What did you implement:

Fixes #1200

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

go test contrib/trivy/parser and go run contrib/trivy/cmd parse -d results -f trivy-vuln

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES.

Copy link
Collaborator

@sadayuki-matsuno sadayuki-matsuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadayuki-matsuno sadayuki-matsuno merged commit 0179f42 into future-architect:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trivy-to-vuls doesn't support latest trivy results
2 participants