Skip to content

feat(futo-backups-bot): repeat investigations - #46

Merged
zackpollard merged 1 commit into
fix/support-attachmentsfrom
feat/support-investigation-retries
Oct 22, 2026
Merged

zackpollard merged 1 commit into
fix/support-attachmentsfrom
feat/support-investigation-retries

Conversation

@zackpollard

@zackpollard zackpollard commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Part 2/7, based on #45: add staff-only investigation retries with an optional prompt, original issue and recent conversation, bypass triage and preserve queue acknowledgement after announcement failures; validated with 155 bot tests and Columbo race tests.

@futo-kritika

futo-kritika Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Re-runViewConfidence Score: 4/5

[Medium risk] In agent.go, a staff retry with no extra prompt still appends "Additional staff request:" followed by nothing. The reported P2 touches this only as a missing test, and the review does not address the dangling label. The risk rating rests on ordinary application logic across the Discord bot and the Columbo worker, which a revert undoes, plus an internal staff-only endpoint guarded by role checks.

Approved

Findings

Earlier findings (1 resolved)

Summary

Adds staff-triggered investigation retries with prompts and recent ticket context.

SupportService routes staff commands and modal submissions into retry requests containing the original issue and bounded recent conversation. Columbo's worker bypasses triage for staff requests, while Runner.Investigate adds the retry context to its model message. The latest change catches staff-announcement failures in SupportService so they do not replace the queued acknowledgement with the generic interaction error.

What's good

  • The announcement-failure regression test verifies that accepted investigations still receive a queued acknowledgement.
Review context · 0/6 commands
  • Commands run: none

Reviews (2) · Last reviewed commit: "feat(futo-backups-bot): repeat investiga..." · openai/gpt-6.1-sol · $0.39

Comment thread packages/columbo/internal/agent/agent.go
Comment thread packages/futo-backups-bot/src/services/support.service.ts Outdated

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 4/5 with medium risk at f0e75a3.

@zackpollard
zackpollard force-pushed the feat/support-investigation-retries branch from f0e75a3 to d494ac5 Compare October 22, 2026 18:05

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 4/5 with medium risk at d494ac5.

@zackpollard
zackpollard added this pull request to stack #51 October 22, 2026 18:28
@zackpollard
zackpollard merged commit de5f249 into main Oct 22, 2026
22 of 30 checks passed
@zackpollard
zackpollard deleted the feat/support-investigation-retries branch October 22, 2026 20:05
This was referenced Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants