Skip to content

feat(yucca-metrics-worker): export beta invite counts - #24

Merged
nutgood merged 1 commit into
mainfrom
feat/invite-metrics
Oct 21, 2026
Merged

nutgood merged 1 commit into
mainfrom
feat/invite-metrics

Conversation

@nutgood

@nutgood nutgood commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Exports a beta_invites gauge (by source and state) from the userAllowlist table for the invites dashboard.

@futo-kritika

futo-kritika Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Re-runKritika Review

Exports beta invite counts by source and state.

No findings

Confidence 4/5 · low risk: The account checked the userAllowlist table in yucca-api, but not that the worker's own src/schema DB type includes it, which the new repository's typed query relies on. Nor did it check that the worker's database role can read the table. The risk is low because this is a read-only gauge on a 5-minute cron with errors caught, and a revert undoes it.

Approved

Summary

Adds a grouped allowlist query and a scheduled beta_invites gauge, with service tests covering zero-filling and database failures. Source classification prioritizes Discord identity, then a successful invite-email timestamp; state classification prioritizes redemption over invitation. The service follows the worker’s existing scheduling and error-handling conventions.

What's good

  • Zero-fills all nine label combinations so emptied groups do not retain previous counts.
  • Skips recording on database failure rather than publishing misleading zero counts.
Review context · 0/6 commands
  • Commands run: none

Reviews (1) · Last reviewed commit: "feat(yucca-metrics-worker): export beta..." · openai/gpt-6.1-sol · $0.09

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 4/5 with low risk at 30e39e1.

@nutgood
nutgood merged commit 40d94b0 into main Oct 21, 2026
17 checks passed
@nutgood
nutgood deleted the feat/invite-metrics branch October 21, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants