Up and down keys change volume only if video focused #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent with other major video apps.
|
Please sign our contributor license agreement at https://cla.futo.org |
|
Please sign our contributor license agreement at https://cla.futo.org |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables vertical scrolling using the Up and Down arrow keys on the keyboard if the video is not focused, which previously did not work in most of the UI. This improves accessibility for keyboard users and is consistent with other major video apps such as YouTube, Crunchyroll, and Twitch. To supplement, I focus the video container when the user enters fullscreen so the arrows control volume at that point.
I'm not a big fan of passing a child element a reference to an ancestor, but this pattern is consistent with code elsewhere in the app. I would prefer to factor the event listeners out of the
PlayerControlsViewbut I went with a lighter touch here to start.If preserving the previous global functionality as an option is desired, I could add a user setting for toggling this.