Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure blob storageのコンテナ操作の実装 #169

Merged
merged 20 commits into from
Oct 4, 2024
Merged

Conversation

harudra
Copy link
Contributor

@harudra harudra commented Oct 2, 2024

概要

user作成後にコンテナを作ることと、user削除後にコンテナも同時に消すことの実装が終わりました。

関連タスク

Close #166

やったこと

コンテナ名は'user{user_id}としています。

やらないこと

レビュー事項

補足 参考情報

api/v2/cruds/user.py Outdated Show resolved Hide resolved
api/v2/models/user.py Outdated Show resolved Hide resolved
api/v2/routers/user.py Outdated Show resolved Hide resolved
api/v2/schemas/user.py Outdated Show resolved Hide resolved
api/v2/utils/config.py Show resolved Hide resolved
api/v2/cruds/user.py Show resolved Hide resolved
Copy link
Member

@shun-harutaro shun-harutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI でビルドが完了してないね。poetry 周りのエラーが出てる。
レビューの修正と、忘れずリント・整形してからpushよろです。

@harudra
Copy link
Contributor Author

harudra commented Oct 2, 2024

CIのビルドって何ですか

@shun-harutaro
Copy link
Member

CIのビルドって何ですか

https://github.com/futaringoto/futarin-api/actions/runs/11143664594/job/30971026694?pr=169
push する度に、リントとテストを自動でやってる(CI)けど、docker-compose build する時点でエラーになってる

@shun-harutaro
Copy link
Member

バッチリ

Copy link
Member

@shun-harutaro shun-harutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shun-harutaro shun-harutaro merged commit 8e916f8 into main Oct 4, 2024
1 check passed
@shun-harutaro shun-harutaro deleted the feat/#166_azure branch October 4, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add: azure blob storageに音声ファイルを保存する
2 participants