Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exportBrep instead of step (faster save and read) #96

Merged
merged 1 commit into from
Nov 18, 2024
Merged

exportBrep instead of step (faster save and read) #96

merged 1 commit into from
Nov 18, 2024

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Nov 10, 2024 •
edited
Loading

Thanks for the suggestion @adam-urbanczyk

@shimwell shimwell changed the title exportBrep instead of step exportBrep instead of step (faster save and read) Nov 10, 2024
@shimwell
Copy link
Member Author

a random datapoint
for a model I have that makes a 4mb dagmc.h5m file
this takes 10.5 seconds with brep method and 12.5 seconds with the current step method.

@shimwell shimwell merged commit 61ddaf2 into main Nov 18, 2024
6 checks passed
@adam-urbanczyk
Copy link

FYI: CadQuery/cadquery#1700 has binary brep export too. IDK if gmsh can import, but it is worth checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shimwell @adam-urbanczyk