Skip to content

Upgraded firebase_core to 0.5.0 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2020
Merged

Upgraded firebase_core to 0.5.0 #19

merged 1 commit into from
Sep 13, 2020

Conversation

ciriousjoker
Copy link
Contributor

@ciriousjoker ciriousjoker commented Sep 9, 2020 •
edited
Loading

Breaking changes:

  • User -> LitUser (freezed doesn't support prefixes)
  • FirebaseUser -> User
  • getSignedInUser() is no longer async

Fixes #8

@ciriousjoker
Upgraded firebase_core to 0.5.0
8e21ed8 
Breaking changes:
- User -> LitUser (freezed doesn't support prefixes)
- FirebaseUser -> User
- getSignedInUser() is no longer async
funwithflutter
funwithflutter requested changes Sep 10, 2020
View reviewed changes
Copy link
Owner

@funwithflutter funwithflutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks. I'll need to update the docs and the example to add Firebase.initializeApp(). Once this is merged I'll do that update the Pub version!

lib/src/presentation/lit_auth_ui.dart
final user = context.watch<LitUser>();
return user.when(
(user) => authenticated,
(dynamic user) => authenticated,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch the dynamic here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the dynamics, the compiler complained

@funwithflutter funwithflutter merged commit b88d862 into funwithflutter:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funwithflutter funwithflutter funwithflutter requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compatibility with cloud_firestore@0.14.0

2 participants

@ciriousjoker @funwithflutter