Medium Crawler 개발 완료 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goinhacker
requested changes
Oct 29, 2017
| sd ! Result(findArticle(body.utf8String)) | ||
| } | ||
| case resp@HttpResponse(code, _, _, _) => | ||
| log.info("Request failed, response code: " + code) |
| resp.discardEntityBytes() | ||
| } | ||
|
|
||
| def encodeUrl(url: String) : String = { |
There was a problem hiding this comment.
몬가 이미 만들어진 라이브러리가 있을 법한 함수네요.
이미 만들어진게 없다면 공통 유틸리티로 빼주시면 다른 모듈에서도 사용할 수 있을 것 같네요.
| private val articleCrawler = | ||
| context.system.actorOf(Props[MediumArticleCrawler], name = "mediumArticleCrawler") | ||
|
|
||
| final implicit val materializer: ActorMaterializer = |
There was a problem hiding this comment.
딱히 사용하는 곳은 없는 것 같은데, 어떤 역할을 하는 건가요??
| } | ||
| log.info("end of response ok") | ||
| case resp@HttpResponse(code, _, _, _) => | ||
| log.info("Request failed, response code: " + code) |
|
PR을 받았는데 잊었던 건지.. 아님 못받은 건지... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
참고이슈 : funfunStudy/funfunnet#21
일단 medium 사이트는 샘플로 아래 3개 등록했습니다.