Skip to content

[FF-2244] - Code cleanup on FunFair.CodeAnalysis.sln #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

github-actions[bot]
Copy link

Description

Related Issue\Feature

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Removed no-longer used code

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • There are no Resharper\static code analysis errors anywhere in the solution.
  • I have ONLY run a code clean-up on any files I have modified to make sure they are in the correct format and no others.
  • I have added tests to cover my changes.
  • I have run the code and quickly verified it all works to my satisfaction.
  • All new/modified code has sufficient logging to be able to diagnose what is wrong.
  • All new and existing tests passed.
  • All new/modified public interfaces/classes have are documented with xmldoc comments.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.

@github-actions github-actions bot added the auto-pr Pull request created automatically label Apr 19, 2021
@credfeto credfeto marked this pull request as ready for review April 19, 2021 16:11
@credfeto credfeto requested a review from a team as a code owner April 19, 2021 16:11
credfeto
credfeto previously approved these changes Apr 19, 2021
@credfeto
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the cleanup/ff-2244/FunFair.CodeAnalysis.sln branch from 7ab652f to e279434 Compare April 19, 2021 17:26
@credfeto credfeto merged commit d5e96cd into master Apr 19, 2021
@credfeto credfeto deleted the cleanup/ff-2244/FunFair.CodeAnalysis.sln branch April 19, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-pr Pull request created automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant