Skip to content

Conversation

@calvinleungyk
Copy link
Contributor

No description provided.

@calvinleungyk calvinleungyk requested a review from dev1-fund3 May 24, 2019 12:10
self._refresh_token = authorization_grant.refresh_token
self._token_expire_time = authorization_grant.expire_at
time_until_session_refresh = (self._token_expire_time -
dt.utcnow().timestamp() - 30.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the 30. a REFRESH_BUFFER_TIME constant at the top.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dev1-fund3
dev1-fund3 previously approved these changes May 24, 2019
Copy link
Contributor

@dev1-fund3 dev1-fund3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor comments that could be changed, but overall logic is OK.

@calvinleungyk calvinleungyk merged commit 6545a8c into master May 28, 2019
@calvinleungyk calvinleungyk deleted the dev/builtin_session_refresh branch May 28, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants